Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some files out of /shared and rename to upper case #18363

Merged
merged 5 commits into from
Mar 21, 2020
Merged

Move some files out of /shared and rename to upper case #18363

merged 5 commits into from
Mar 21, 2020

Commits on Mar 21, 2020

  1. Rename lower case isomorphic default exports modules to upper case na… 

    …med exports

We're somewhat inconsistent here between e.g. ReactLazy and memo.

Let's pick one.

This also moves the responder, fundamental, scope creators from shared
since they're isomorphic and same as the other creators.
    @sebmarkbage
    sebmarkbage committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    b797818 View commit details
    Browse the repository at this point in the history

  2. Move some files that are specific to the react-reconciler from shared 

    Individual renderers are allowed to deep require into the reconciler.
    @sebmarkbage
    sebmarkbage committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    21f393e View commit details
    Browse the repository at this point in the history

  3. Move files specific to react-dom from shared 

    react-interactions is right now dom specific (it wasn't before) so we can
type check it together with other dom stuff. Avoids the need for
a shared ReactDOMTypes to be checked by RN for example.
    @sebmarkbage
    sebmarkbage committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    dd1a013 View commit details
    Browse the repository at this point in the history

  4. Move ReactWorkTags to the reconciler

    @sebmarkbage
    sebmarkbage committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    8d700df View commit details
    Browse the repository at this point in the history

  5. Move createPortal to export from reconciler 

    Otherwise Noop can't access it since it's not allowed deep requires.
    @sebmarkbage
    sebmarkbage committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    c581aa3 View commit details
    Browse the repository at this point in the history