Add container to event listener signature #18075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
requested review from
bvaughn,
sebmarkbage,
captbaritone,
necolas and
acdlite
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Details of bundled changes.Comparing: f48a5e6...539baea react-dom
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (stable) |
trueadm
force-pushed
the
roots-phase2
branch
from
b65f791
to
539baea
Compare
Details of bundled changes.Comparing: f48a5e6...539baea react-dom
Size changes (experimental) |
threepointone
approved these changes
Feb 19, 2020
gaearon
reviewed
Feb 19, 2020
| @@ -289,6 +325,7 @@ export function attemptToDispatchEvent( | |||
| topLevelType: DOMTopLevelEventType, | |||
| eventSystemFlags: EventSystemFlags, | |||
| nativeEvent: AnyNativeEvent, | |||
| container: Document | Element | Node, | |||
There was a problem hiding this comment.
All of the other signatures have it before nativeEvent so this was a bit confusing.
There was a problem hiding this comment.
I guess the ones below don't. It would be nice to preserve a consistent order because it's easy to mix them up. Hopefully Flow would catch that.
There was a problem hiding this comment.
Flow can catch it, and it did, because I've hacked this file abount so much in the last few days and it's saved my ass a bunch :)
I can refine the order in a follow up though, you're right, consistency helps here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is a pre-requisite for the modern root event system.
For the new event system that uses root containers to register nodes. For this to work, we need a sane way of knowing what the container is, so we can properly find ancestors.
We could use
nativeEvent.currentTargetbut that seems fragile, as thecurrentTargetcan change when the event bubbles, or might not be there if we bypass native events entirely (if we ever decided to addonBeforeBlurto the plugin event system).Instead, we can bind the
containerto the dispatch function, as we do with other arguments. This then allows us to know the container correctly in all cases. Furthermore, we pass this to the event replaying logic so it can properly replay the event with the correctcontainer.