[Flight] Chunks API #17398
Merged
[Flight] Chunks API #17398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3062dfc:
|
Details of bundled changes.Comparing: 4c27037...3062dfc react
react-native-renderer
react-reconciler
react-dom
react-art
react-test-renderer
ReactDOM: size: 🔺+0.2%, gzip: 🔺+0.1% React: size: 🔺+0.2%, gzip: 🔺+0.1% Size changes (stable) |
Details of bundled changes.Comparing: 4c27037...3062dfc react
react-dom
react-test-renderer
react-native-renderer
react-art
react-reconciler
ReactDOM: size: 🔺+0.3%, gzip: 🔺+0.2% React: size: 🔺+1.3%, gzip: 🔺+0.9% Size changes (experimental) |
sebmarkbage
commented
Nov 18, 2019
| $$typeof: REACT_CHUNK_TYPE, | ||
| query: function() { | ||
| return query.apply(null, args); | ||
| }, |
There was a problem hiding this comment.
In Flight, this function will be replaced by one that suspends on the data, as well as as a render that suspends on the code.
sebmarkbage
commented
Nov 18, 2019
gaearon
reviewed
Nov 19, 2019
gaearon
requested changes
Nov 19, 2019
gaearon
reviewed
Nov 19, 2019
|
QQ: From what I can see, this looks like it would work in legacy mode too, right? If so, is that intentional? |
sebmarkbage
force-pushed
the
chunks
branch
3 times, most recently
from
62c9f11
to
74318e2
Compare
This allows the query and args to be updated.
Not really a supported use case but for consistency I guess.
gaearon
approved these changes
Dec 18, 2019
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
* Add feature flags * Add Chunk type and constructor * Wire up Chunk support in the reconciler * Update reconciler to reconcile Chunks against the render method This allows the query and args to be updated. * Drop the ref. Chunks cannot have refs anyway. * Add Chunk checks in more missing cases * Rename secondArg * Add test and fix lazy chunks Not really a supported use case but for consistency I guess. * Fix fragment test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very early experiment. We just need something to play with.
This is a new core API but it's not really meant to be used without Flight. Instead Flight will produce these "chunks" from its payload. The primary purpose of this in core is to ensure the reconciler can update the same component instance with new data.
It can be used without Flight by running it in the same environment and it works fine. That is a nice property because a) it means you can get started running this code in a client-only environment and debug in browser. b) it describes the semantics in a standalone way which is how the type system thinks about it, so it's nice to be able to think about it this way.
This implementation doesn't support Context. Exposing React's context wouldn't be the same semantics as with Flight so it's not super easy and requires more code to actually support Context in this mode. That's unfortunate.