[Flight] Basic Integration Test #17307
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5e3e1e7:
|
| }; | ||
| } | ||
|
|
||
| async function waitForDOMChange(container) { |
There was a problem hiding this comment.
This is kinda wonky but I wanted to check for next mutation specifically rather than manually wait for models. Since React itself would wait for models and I want to test it waits correctly.
There was a problem hiding this comment.
Isn’t this what async act is for? Why isn’t it sufficient? It’s supposed to force flush even if it suspends and wait for nested promises.
What’s missing and can we fix that?
There was a problem hiding this comment.
Lol I forgot about it. Let me try it
|
OK this should work. I need two of them to flush Promise ticks for both client and server. |
|
ready for another |
| // We can now show the sidebar. | ||
| resolvePhotosModel(); | ||
| await act(async () => { | ||
| jest.runAllTimers(); |
There was a problem hiding this comment.
There are no timers in any of your test helpers so you don't need these calls.
I would put resolvePhotosModel inside the act call, even though it happens to work without it:
await act(async () => {
resolvePhotosModel();
});There was a problem hiding this comment.
The Node server uses setImmediate for scheduling. So I need at least one per server work request I think.
There was a problem hiding this comment.
We probably need a FlgihtServer.act(...) for that but let's run the timers for now.
packages/react-dom/src/__tests__/ReactFlightIntegration-test.js
Outdated
Show resolved
Hide resolved
packages/react-dom/src/__tests__/ReactFlightIntegration-test.js
Outdated
Show resolved
Hide resolved
packages/react-dom/src/__tests__/ReactFlightIntegration-test.js
Outdated
Show resolved
Hide resolved
packages/react-dom/src/__tests__/ReactFlightIntegration-test.js
Outdated
Show resolved
Hide resolved
|
I pushed an update that shims |
|
With act in CM, prod experimental build fails (?!) |
packages/react-dom/src/__tests__/ReactFlightIntegration-test.js
Outdated
Show resolved
Hide resolved
This adds a basic integration test where we actually feed the model to ReactDOM components and use Suspense. The test verifies that we can stream data and reveal more content as it happens. We also verify errors work.