Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN] Hoist static deepDiffer options object #17303

Merged
merged 1 commit into from
Nov 7, 2019
Merged

[RN] Hoist static deepDiffer options object #17303

merged 1 commit into from
Nov 7, 2019

Conversation

motiz88
Copy link
Contributor

@motiz88 motiz88 commented Nov 7, 2019

Hoists the options object literal from defaultDiffer to the module scope so it's not recreated on every prop update. Addresses #17282 (comment).

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 7, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 67c59a7:

Sandbox Source
weathered-fog-qes65 Configuration

Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sizebot
Copy link

sizebot commented Nov 7, 2019

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 67c59a7

@sizebot
Copy link

sizebot commented Nov 7, 2019

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 67c59a7

@gaearon gaearon merged commit 38dd17a into facebook:master Nov 7, 2019
@gaearon
Copy link
Collaborator

gaearon commented Nov 7, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants