Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SuspenseList to experimental package #17130

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Oct 17, 2019

Also moves unstable_withSuspenseConfig but keeps the prefix since that may or may not become a public API.

Copy link
Collaborator

@sebmarkbage sebmarkbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to codemod.

@sizebot
Copy link

sizebot commented Oct 17, 2019

Size changes (experimental)

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 1f1f19c

@sizebot
Copy link

sizebot commented Oct 17, 2019

Size changes (stable)

React: size: -0.6%, gzip: -0.6%

Details of bundled changes.

Comparing: 685ed56...1f1f19c

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js 0.0% 0.0% 117.66 KB 117.67 KB 29.87 KB 29.87 KB UMD_DEV
react.production.min.js -0.6% -0.6% 12.4 KB 12.32 KB 4.88 KB 4.85 KB UMD_PROD
react.profiling.min.js -0.5% -0.5% 15.91 KB 15.83 KB 5.97 KB 5.94 KB UMD_PROFILING
react.development.js 0.0% -0.0% 72.76 KB 72.76 KB 19.09 KB 19.09 KB NODE_DEV
react.production.min.js -2.3% -2.1% 6.66 KB 6.51 KB 2.77 KB 2.71 KB NODE_PROD
React-dev.js +0.1% +0.1% 70.39 KB 70.49 KB 18.16 KB 18.18 KB FB_WWW_DEV
React-prod.js -2.1% -1.8% 17.49 KB 17.13 KB 4.56 KB 4.48 KB FB_WWW_PROD
React-profiling.js -2.1% -1.8% 17.49 KB 17.13 KB 4.56 KB 4.48 KB FB_WWW_PROFILING

Generated by 🚫 dangerJS against 1f1f19c

@acdlite acdlite force-pushed the move-to-experimental branch 2 times, most recently from eda6cf6 to e57bd82 Compare October 18, 2019 19:51
Also moves `withSuspenseConfig`
@acdlite acdlite merged commit c47f593 into facebook:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants