Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable risky work loop changes #16771

Merged
merged 4 commits into from
Sep 13, 2019
Merged

Re-enable risky work loop changes #16771

merged 4 commits into from
Sep 13, 2019

Commits on Sep 12, 2019

  1. Re-enable risky work loop changes 

    The stack of PRs in facebook#16743 was reverted. This adds them back.
    @acdlite
    acdlite committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    1d91c66 View commit details
    Browse the repository at this point in the history

  2. Fork root completion between sync and concurrent 

    Lifts the switch on `workInProgressExitStatus` into
`performConcurrentWorkOnRoot` and `performSyncWorkOnRoot`.
    @acdlite
    acdlite committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    01c39a1 View commit details
    Browse the repository at this point in the history

  3. Add RootLocked exit status, for createBatch API

    @acdlite
    acdlite committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    6bd4359 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2019

  1. Expired tasks should use performSyncWorkOnRoot 

    This lets us get rid of all the `didTimeout` checks after completing
a root.
    @acdlite
    acdlite committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    8c3e455 View commit details
    Browse the repository at this point in the history