Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-events] Ensure we restore currentInstance + currentTimers #16758

Merged

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Sep 12, 2019

This fixes an issue where we weren't correctly restoring the currentInstance and currentTimers bindings in the responder event system. This should hotfix and internal issue found.

@sizebot
Copy link

sizebot commented Sep 12, 2019

ReactDOM: size: 0.0%, gzip: -0.0%

Details of bundled changes.

Comparing: 3717c25...162db60

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% -0.0% 117.12 KB 117.12 KB 36.86 KB 36.86 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 142.1 KB 142.1 KB 37.12 KB 37.12 KB UMD_DEV
ReactDOM-dev.js 0.0% 0.0% 954.66 KB 954.97 KB 210.71 KB 210.72 KB FB_WWW_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.8 KB 19.8 KB 7.36 KB 7.36 KB UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 57.46 KB 57.46 KB 15.82 KB 15.82 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.78 KB 3.78 KB 1.53 KB 1.53 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 11.19 KB 11.19 KB 4.16 KB 4.16 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 702 B 701 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.61 KB 3.61 KB 1.48 KB 1.48 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.96 KB 10.96 KB 4.09 KB 4.09 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.04 KB 1.04 KB 633 B 632 B NODE_PROD
react-dom.development.js 0.0% 0.0% 930.44 KB 930.75 KB 210.11 KB 210.13 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 113.47 KB 113.47 KB 36.55 KB 36.55 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 116.99 KB 116.99 KB 37.56 KB 37.55 KB UMD_PROFILING
react-dom.development.js 0.0% 0.0% 924.52 KB 924.83 KB 208.48 KB 208.49 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 113.4 KB 113.4 KB 35.86 KB 35.86 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.13 KB 20.13 KB 7.51 KB 7.5 KB NODE_PROD
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 380.45 KB 380.8 KB 69.36 KB 69.41 KB FB_WWW_PROD
ReactDOM-profiling.js +0.1% +0.1% 386.49 KB 386.84 KB 70.46 KB 70.51 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 138.04 KB 138.04 KB 36.11 KB 36.11 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.73 KB 19.73 KB 7.35 KB 7.34 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.71 KB 60.71 KB 15.84 KB 15.84 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.75 KB 10.75 KB 3.67 KB 3.67 KB UMD_PROD
ReactDOMServer-dev.js 0.0% -0.0% 142.55 KB 142.55 KB 35.72 KB 35.71 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% -0.0% 48.58 KB 48.58 KB 11.11 KB 11.11 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.39 KB 60.39 KB 15.72 KB 15.72 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.87 KB 3.87 KB 1.51 KB 1.51 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.49 KB 10.49 KB 3.57 KB 3.57 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.1 KB 1.1 KB 668 B 667 B NODE_PROD

Generated by 🚫 dangerJS against 162db60

@trueadm trueadm merged commit 35a202d into facebook:master Sep 12, 2019
@trueadm trueadm deleted the ensure-current-instance-gets-restored branch September 12, 2019 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants