Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change trackedTouchCount console.error to warn #16750

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

ascorbic
Copy link
Contributor

This is a workaround for an Android OS bug causing errors in React Native.

The very old bug facebook/react-native#15059 is caused by certain Android builds' handling of three-finger screenshots. The OS sends three touchcancel events, but only two touchstart events. This causes unavoidable red box errors. This PR changes the console.error to console.warn. This behaviour is consistent with similar touch event errors.

@sizebot
Copy link

sizebot commented Sep 11, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 0f1d33d

Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants