-
Notifications
You must be signed in to change notification settings - Fork 47.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react-events] Remove stopPropagation (Press) + use document for delegation #16730
[react-events] Remove stopPropagation (Press) + use document for delegation #16730
Conversation
Details of bundled changes.Comparing: 4905590...4200261 react-events
|
Any "responder" can still do |
@necolas True, but this was an explicit prop, so maybe my wording was a bit off. People can always do anything in the responders themselves. |
The point is that moving listeners back to the document means that the system can collide with external listeners also attached to the document. That's aside from remove the |
@necolas I found a bunch of subtle bugs today when moving all to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can address potential collisions on the document
later.
I found a bunch of subtle bugs today when moving all to body
Might be worth documenting those bugs in a comment on this PR so there's a record if this comes up again in the future.
This PR does two things:
stopPropagation
prop from the Press responder module. After internal inspection, this prop seems to have been misused internally because a misunderstanding on what it does. It thus makes sense to remove this prop, because it was always intended to be a temporary hack.document
. Given we no longer can usestopPropagation
we no longer have the issue of blocking other event systems already on thedocument
.