using the wrong renderer's act() should warn #15756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dates like it says. it uses a real object as the sigil (instead of just a boolean). specifically, it uses a renderer's flushPassiveEffects as the sigil. We also run tests for this separate from our main suite (which doesn't allow loading multiple renderers in a suite), but makes sure to run this in CI as well.
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: 401065f...c0dc398 react-dom
react-art
react-native-renderer
react-test-renderer
react-reconciler
Generated by 🚫 dangerJS |
acdlite
reviewed
May 29, 2019
acdlite
approved these changes
May 29, 2019
|
updated the PR to use an explicit export (from |
gaearon
reviewed
May 29, 2019
| if (__DEV__) { | ||
| if ( | ||
| ReactCurrentActingRendererSigil.current !== null && | ||
| // use the function flushPassiveEffects directly as the sigil |
| // so this comparison is expected here | ||
| ReactCurrentActingRendererSigil.current !== ReactActingRendererSigil | ||
| ) { | ||
| // it looks like we're using the wrong matching act(), so log a warning |
There was a problem hiding this comment.
This comment kinda repeats the warning?
threepointone
commented
May 29, 2019
| "It looks like you're using the wrong act() around your test interactions.\n" + | ||
| 'Be sure to use the matching version of act() corresponding to your renderer:\n\n' + | ||
| '// for react-dom:\n' + | ||
| "import {act} from 'react-test-utils';\n" + |
There was a problem hiding this comment.
there's no such package either 🤦♂️
Merged
This was referenced Aug 17, 2019
This was referenced Mar 10, 2020
This was referenced Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
via #15319
(redid #15399, removed the changes that didn't even belong in it.)
So tl;dr this PR -
This solves 2 specific problems -
(Please see #15399 for the long spiel on the mechanics for this.)