Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize CircleCI jobs using workflows #15704

Merged
merged 1 commit into from
May 22, 2019

Conversation

acdlite
Copy link
Contributor

@acdlite acdlite commented May 22, 2019

Updates the CircleCI config to use the workflows feature to run jobs in parallel, instead of the parallelism option. This change alone doesn't improve the overall build time much, since almost all of the total time is spent running the Rollup script, which runs entirely sequentially. But it does improve reporting, and should make it easier to add additional parallel jobs in the future.

(My original motivation for this PR was because I want to use a workflow trigger to run a chron job for the fuzz tester.)

PRs report more granular information about the CI status:
Screen Shot 2019-05-21 at 8 41 42 PM

The Workflows view includes a nice flowchart. Note how the Rollup script takes the bulk of the time, as you would expect. (Parallelizing that step would be an easy win.)

Screen Shot 2019-05-21 at 8 34 12 PM

Updates the CircleCI config to use the workflows features to run jobs in
parallel, instead of the `parallelism` option. This change alone doesn't
improve the overall build time much, since almost all of the total time
is spent running the Rollup script, which runs entirely sequentially.
But it does improve reporting, and should make it easier to add
additional parallel jobs in the future.
@acdlite acdlite force-pushed the use-circleci-workflows branch 12 times, most recently from 4e39d37 to 65754f4 Compare May 22, 2019 03:24
@acdlite acdlite changed the title [DO NOT MERGE] Use CircleCI workflows Parallelize CircleCI jobs using workflows May 22, 2019
@acdlite acdlite requested review from gaearon, bvaughn and trueadm May 22, 2019 03:40
@acdlite acdlite marked this pull request as ready for review May 22, 2019 03:44
@acdlite acdlite force-pushed the use-circleci-workflows branch from 65754f4 to fecd448 Compare May 22, 2019 03:45
@sophiebits
Copy link
Collaborator

ooooo very nice

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bvaughn
Copy link
Contributor

bvaughn commented May 22, 2019

Slick!

@acdlite acdlite merged commit f3109ad into facebook:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants