Inform DevTools of commit priority level #15664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ReactDOM: size: -0.0%, gzip: -0.0% Details of bundled changes.Comparing: 0bd9b5d...4c5a0e8 react-dom
react-art
react-native-renderer
react-test-renderer
react-reconciler
Generated by 🚫 dangerJS |
bvaughn
force-pushed
the
devtools-commit-priority-level
branch
from
a925a01 to
c1e8e2d
Compare
|
🤔 Looks like importing
|
bvaughn
changed the title
gaearon
reviewed
May 16, 2019
| const currentTime = requestCurrentTime(); | ||
| const priorityLevel = inferPriorityFromExpirationTime( | ||
| currentTime, | ||
| expirationTime, |
There was a problem hiding this comment.
Should these be DEV/PROFILE only?
There was a problem hiding this comment.
Interesting. Yeah probably wouldn't hurt!
bvaughn
commented
May 17, 2019
| const priorityLevel = inferPriorityFromExpirationTime( | ||
| currentTime, | ||
| expirationTime, | ||
| ); |
There was a problem hiding this comment.
Andrew mentioned maybe we could use getCurrentPriorityLevel() here rather than inferring the priority level. I don't think the priority level a Fiber was scheduled with will necessarily match the current priority level though. (Maybe I misunderstood his suggestion.)
There was a problem hiding this comment.
If you call getCurrentPriorityLevel inside commitRoot (not commitRootImpl, since that's always run at ImmediatePriority — it has to be the wrapper) then it will match the priority of the commit, which is not necessarily the same thing as the priority at which something was scheduled because multiple priorities can get batched.
This approach seems fine, though.
It's possible we may eventually track the priority on the update object.
gaearon
reviewed
May 20, 2019
| @@ -11,6 +11,10 @@ | |||
|
|
|||
| describe('ReactIncrementalErrorReplay-test', () => { | |||
| it('copies all keys when stashing potentially failing work', () => { | |||
| // Include a renderer to ensure host config files are properly shimmed. | |||
| // Otherwise transient imports may cause an invariant. | |||
| require('react-dom'); | |||
There was a problem hiding this comment.
I landed another PR which needed this fix so you should be able to revert this file
bvaughn
force-pushed
the
devtools-commit-priority-level
branch
from
e65faef to
dc7dcdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React now informs DevTools of the commit priority level (so the Profiler can display and potentially filter on the info).
Demo