Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event API: remove isTargetDirectlyWithinEventComponent #15546

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Apr 30, 2019

With the event API, we have a context method called isTargetDirectlyWithinEventComponent that is only used in Hover.js. It turns out, this isn't the behaviour we want and we already have a better context method called isTargetWithinEventResponderScope. If we switch to using this, we get the desired behaviour, meaning we can remove isTargetDirectlyWithinEventComponent from the codebase – saving bytes and removing one more API on context.

Ref #15257

@sizebot
Copy link

sizebot commented Apr 30, 2019

Details of bundled changes.

Comparing: a6e3000...1b1211e

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.1% -0.0% 818.81 KB 818.39 KB 186.52 KB 186.5 KB UMD_DEV
react-dom.development.js -0.1% -0.0% 813.22 KB 812.8 KB 184.96 KB 184.94 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 103.67 KB 103.67 KB 33.14 KB 33.13 KB NODE_PROD
ReactDOM-dev.js -0.1% -0.0% 837.54 KB 837.12 KB 186.37 KB 186.36 KB FB_WWW_DEV
ReactDOM-prod.js -0.1% -0.0% 344.34 KB 343.98 KB 63.7 KB 63.68 KB FB_WWW_PROD
ReactDOM-profiling.js -0.1% -0.0% 349.79 KB 349.42 KB 64.71 KB 64.69 KB FB_WWW_PROFILING
react-dom-unstable-fire.development.js -0.1% -0.0% 819.14 KB 818.72 KB 186.65 KB 186.64 KB UMD_DEV
react-dom-unstable-fire.development.js -0.1% -0.0% 813.54 KB 813.12 KB 185.09 KB 185.07 KB NODE_DEV
react-dom-unstable-fire.profiling.min.js 0.0% -0.0% 107.01 KB 107.01 KB 33.99 KB 33.99 KB NODE_PROFILING
ReactFire-dev.js -0.1% -0.0% 836.72 KB 836.3 KB 186.37 KB 186.35 KB FB_WWW_DEV
ReactFire-prod.js -0.1% -0.0% 332.33 KB 331.97 KB 61.3 KB 61.28 KB FB_WWW_PROD
ReactFire-profiling.js -0.1% -0.0% 337.75 KB 337.39 KB 62.28 KB 62.26 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10.69 KB 10.69 KB 3.66 KB 3.67 KB UMD_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10.43 KB 10.43 KB 3.56 KB 3.56 KB NODE_PROD
ReactDOMServer-dev.js 0.0% 0.0% 134.79 KB 134.79 KB 34.63 KB 34.63 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% 0.0% 46.91 KB 46.91 KB 10.77 KB 10.77 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% -0.0% 134.57 KB 134.57 KB 35.54 KB 35.54 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% 0.0% 19.91 KB 19.91 KB 7.5 KB 7.5 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.21 KB 1.21 KB 704 B 705 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.49 KB 3.49 KB 1.41 KB 1.41 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.05 KB 1.05 KB 635 B 636 B NODE_PROD

Generated by 🚫 dangerJS

@trueadm trueadm merged commit ec6691a into facebook:master Apr 30, 2019
@trueadm trueadm deleted the remove-directly-within-evetn branch April 30, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants