Event API: remove isTargetDirectlyWithinEventComponent #15546
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the event API, we have a context method called
isTargetDirectlyWithinEventComponent
that is only used inHover.js
. It turns out, this isn't the behaviour we want and we already have a better context method calledisTargetWithinEventResponderScope
. If we switch to using this, we get the desired behaviour, meaning we can removeisTargetDirectlyWithinEventComponent
from the codebase – saving bytes and removing one more API on context.Ref #15257