React Events: add onFocusVisibleChange to Focus #15516
Conversation
necolas
force-pushed
the
react-events/focus-visible
branch
2 times, most recently
from
efb1149 to
dcee5f8
Compare
| nativeEvent.key === 'Tab' && | ||
| !(nativeEvent.metaKey || nativeEvent.altKey || nativeEvent.ctrlKey) | ||
| ) { | ||
| isGlobalFocusVisible = true; |
There was a problem hiding this comment.
It's probably not ideal to have global focus state being checked / modified in every instance. Should this be handled by a module outside of Flare (using native APIs) that we query for global focus visibility info? Any other ideas?
There was a problem hiding this comment.
We could add a context.isEventComponentWithinResponderScope or context.isResponderTopLevel API that checks if a parent event component in the tree has the same responder and bail-out of this logic?
Details of bundled changes.Comparing: cc5a493...f2776df react-events
Generated by 🚫 dangerJS |
Called when focus visibility changes. Focus is only considered visible if a focus event occurs after keyboard navigation. This provides a way for people to provide visual focus styles for keyboard accessible UIs without those styles appearing if focus is triggered by mouse, touch, pen.
necolas
force-pushed
the
react-events/focus-visible
branch
from
dcee5f8 to
f2776df
Compare
|
I noticed a couple of odd things happening while working on–and unrelated to changes in–this branch. First, the |
|
@necolas This wasn't merged before the other PR that should have addressed the double event issue (the PR for using proper keys for events). I wonder if that fixes this issue. The other bugs sounds like yet another Safari thing we need to handle as an edge case. :/ |
Called when focus visibility changes. Focus is only considered visible if a
focus event occurs after keyboard navigation. This provides a way for people to
provide visual focus styles for keyboard accessible UIs without those styles
appearing if focus is triggered by mouse, touch, pen.
Still working on incorporating a couple more details around when focus is considered visible.
Ref #15257