Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ReactDOM.unstable_createSyncRoot #15504

Merged
merged 2 commits into from
May 13, 2019
Merged

Add ReactDOM.unstable_createSyncRoot #15504

merged 2 commits into from
May 13, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Apr 25, 2019 •
edited
Loading

  • ReactDOM.unstable_createRoot creates a Concurrent Mode root.
  • ReactDOM.unstable_createSyncRoot creates a Batched Mode root. It
    does not support createBatch.
  • ReactDOM.render creates a Legacy Mode root. It will eventually be
    deprecated and possibly moved to a separate entry point, like
    react-dom/legacy.

@sizebot
Copy link

sizebot commented Apr 25, 2019 •
edited
Loading

ReactDOM: size: -0.0%, gzip: -0.1%

Details of bundled changes.

Comparing: 862f499...918d7fd

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js +0.1% +0.1% 828.41 KB 828.87 KB 189.09 KB 189.19 KB UMD_DEV
react-dom.production.min.js -0.0% -0.1% 104.04 KB 104.01 KB 33.83 KB 33.8 KB UMD_PROD
react-dom.profiling.min.js -0.0% -0.2% 107.19 KB 107.17 KB 34.84 KB 34.78 KB UMD_PROFILING
react-dom.development.js +0.1% +0.1% 822.81 KB 823.28 KB 187.53 KB 187.63 KB NODE_DEV
react-dom.production.min.js -0.0% -0.1% 104.03 KB 104.01 KB 33.27 KB 33.25 KB NODE_PROD
react-dom.profiling.min.js -0.0% 0.0% 107.37 KB 107.35 KB 34.15 KB 34.15 KB NODE_PROFILING
ReactDOM-dev.js +0.1% 0.0% 847.43 KB 847.86 KB 189.08 KB 189.16 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 348.08 KB 348.13 KB 64.48 KB 64.49 KB FB_WWW_PROD
ReactDOM-profiling.js 0.0% -0.0% 353.28 KB 353.33 KB 65.47 KB 65.46 KB FB_WWW_PROFILING
react-dom-unstable-fire.development.js +0.1% +0.1% 828.73 KB 829.21 KB 189.23 KB 189.34 KB UMD_DEV
react-dom-unstable-fire.production.min.js -0.0% -0.1% 104.05 KB 104.03 KB 33.84 KB 33.81 KB UMD_PROD
react-dom-unstable-fire.profiling.min.js -0.0% -0.2% 107.2 KB 107.18 KB 34.85 KB 34.79 KB UMD_PROFILING
react-dom-unstable-fire.development.js +0.1% +0.1% 823.13 KB 823.62 KB 187.66 KB 187.78 KB NODE_DEV
react-dom-unstable-fire.production.min.js -0.0% -0.0% 104.04 KB 104.02 KB 33.28 KB 33.26 KB NODE_PROD
react-dom-unstable-fire.profiling.min.js -0.0% -0.0% 107.39 KB 107.37 KB 34.16 KB 34.16 KB NODE_PROFILING
ReactFire-dev.js +0.1% +0.1% 846.62 KB 847.07 KB 189.05 KB 189.15 KB FB_WWW_DEV
ReactFire-prod.js 0.0% -0.0% 336.06 KB 336.11 KB 62.02 KB 62.02 KB FB_WWW_PROD
ReactFire-profiling.js 0.0% 0.0% 341.23 KB 341.28 KB 62.96 KB 62.96 KB FB_WWW_PROFILING
react-dom-test-utils.production.min.js 0.0% -0.1% 10.56 KB 10.56 KB 3.9 KB 3.89 KB UMD_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 10.35 KB 10.35 KB 3.82 KB 3.82 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.76 KB 60.76 KB 15.84 KB 15.85 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.69 KB 10.69 KB 3.67 KB 3.67 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.43 KB 60.43 KB 15.72 KB 15.72 KB NODE_DEV
react-dom-server.browser.development.js 0.0% -0.0% 136.73 KB 136.73 KB 35.99 KB 35.98 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.14 KB 19.14 KB 7.22 KB 7.22 KB UMD_PROD
react-dom-server.browser.development.js 0.0% -0.0% 132.86 KB 132.86 KB 35.05 KB 35.05 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.07 KB 19.07 KB 7.21 KB 7.21 KB NODE_PROD
ReactDOMServer-prod.js 0.0% -0.0% 47.85 KB 47.85 KB 10.98 KB 10.98 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% -0.0% 134.81 KB 134.81 KB 35.6 KB 35.6 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 19.93 KB 19.93 KB 7.51 KB 7.51 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.66 KB 3.66 KB 1.45 KB 1.45 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.21 KB 1.21 KB 707 B 706 B UMD_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.74 KB 3.74 KB 1.43 KB 1.43 KB NODE_DEV

Generated by 🚫 dangerJS

@gaearon gaearon mentioned this pull request Apr 29, 2019
Closed
This was referenced Apr 29, 2019
Merged
Closed
sebmarkbage
sebmarkbage approved these changes May 13, 2019
View reviewed changes
Copy link
Collaborator

@sebmarkbage sebmarkbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Just rename the type.

acdlite added 2 commits May 13, 2019 14:41
@acdlite
Add ReactDOM.unstable_createSyncRoot
7723a44 
- `ReactDOM.unstable_createRoot` creates a Concurrent Mode root.
- `ReactDOM.unstable_createSyncRoot` creates a Batched Mode root. It
does not support `createBatch`.
- `ReactDOM.render` creates a Legacy Mode root. It will eventually be
deprecated and possibly moved to a separate entry point, like
`react-dom/legacy`.
@acdlite
Rename internal ReactRoot types
918d7fd
@acdlite acdlite force-pushed the create-sync-root branch 2 times, most recently from 1d8e59e to 918d7fd Compare May 13, 2019 21:57
@acdlite acdlite merged commit 283ce53 into facebook:master May 13, 2019
@eps1lon eps1lon mentioned this pull request May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

@bvaughn bvaughn Awaiting requested review from bvaughn

@gaearon gaearon Awaiting requested review from gaearon

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acdlite @sizebot @sebmarkbage @facebook-github-bot