Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental event API: Hover module eventdata #15347

Closed
wants to merge 1 commit into from
Closed

Experimental event API: Hover module eventdata #15347

wants to merge 1 commit into from

Conversation

behzad888
Copy link
Contributor

@behzad888 behzad888 commented Apr 7, 2019

Note:
determine eventData and pointerType

{
  pointerType: 'mouse',
  point: { x: number, y: number }
}

Ref #15257

@sizebot
Copy link

sizebot commented Apr 7, 2019

Details of bundled changes.

Comparing: 81a61b1...b074a4e

react-events

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-events.production.min.js 0.0% 🔺+0.3% 512 B 512 B 352 B 353 B NODE_PROD
react-events-press.development.js 0.0% 0.0% 12.88 KB 12.88 KB 3.02 KB 3.02 KB UMD_DEV
react-events-press.development.js 0.0% 0.0% 12.71 KB 12.71 KB 2.98 KB 2.98 KB NODE_DEV
react-events-hover.development.js +39.7% +48.8% 6.74 KB 9.42 KB 1.79 KB 2.66 KB UMD_DEV
react-events-hover.production.min.js 🔺+37.5% 🔺+42.1% 3.02 KB 4.15 KB 1.15 KB 1.63 KB UMD_PROD
react-events-hover.development.js +40.8% +50.3% 6.57 KB 9.25 KB 1.74 KB 2.62 KB NODE_DEV
react-events-hover.production.min.js 🔺+39.7% 🔺+43.6% 2.85 KB 3.99 KB 1.1 KB 1.58 KB NODE_PROD
ReactEventsHover-dev.js +10.1% +6.5% 6.77 KB 7.46 KB 1.76 KB 1.88 KB FB_WWW_DEV
ReactEventsHover-prod.js 🔺+9.9% 🔺+6.1% 5.94 KB 6.52 KB 1.47 KB 1.56 KB FB_WWW_PROD
react-events-focus.development.js 0.0% +0.1% 3.29 KB 3.29 KB 1.11 KB 1.11 KB UMD_DEV
react-events-focus.production.min.js 0.0% -0.3% 1.52 KB 1.52 KB 740 B 738 B UMD_PROD
react-events-focus.production.min.js 0.0% 🔺+0.1% 1.35 KB 1.35 KB 670 B 671 B NODE_PROD
react-events-drag.development.js 0.0% 0.0% 7.8 KB 7.8 KB 2.44 KB 2.44 KB UMD_DEV
react-events-drag.production.min.js 0.0% 🔺+0.1% 3.14 KB 3.14 KB 1.44 KB 1.44 KB NODE_PROD

Generated by 🚫 dangerJS

@matthargett
Copy link
Contributor

what about gaze and pen?

@necolas
Copy link
Contributor

necolas commented Apr 19, 2019

Thanks for taking interest in this work. But I'm closing this PR as master has diverged quite a lot and we're still figuring out event data internally.

@necolas necolas closed this Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants