Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature flags react-dom/unstable-new-scheduler #15309

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Apr 3, 2019

I forgot to account for the CommonJS builds. (I had this change in my local checkout but accidentally didn't commit it.)

I forgot to account for the CommonJS builds. (I had this change in
my local checkout but accidentally didn't commit it.)
@sizebot
Copy link

sizebot commented Apr 3, 2019

ReactDOM: size: 0.0%, gzip: -0.0%

Details of bundled changes.

Comparing: 92a1d8f...5a0f397

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% 0.0% 886.14 KB 886.14 KB 200.15 KB 200.15 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 105.49 KB 105.49 KB 34.15 KB 34.15 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 108.5 KB 108.5 KB 34.76 KB 34.76 KB UMD_PROFILING
react-dom.development.js 0.0% 0.0% 880.76 KB 880.76 KB 198.58 KB 198.59 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 105.48 KB 105.48 KB 33.61 KB 33.61 KB NODE_PROD
react-dom.profiling.min.js 0.0% 0.0% 108.59 KB 108.59 KB 34.19 KB 34.19 KB NODE_PROFILING
ReactDOM-dev.js 0.0% 0.0% 906.93 KB 906.93 KB 200.48 KB 200.48 KB FB_WWW_DEV
react-dom-unstable-fire.development.js 0.0% 0.0% 886.46 KB 886.46 KB 200.28 KB 200.28 KB UMD_DEV
react-dom-unstable-fire.profiling.min.js 0.0% -0.0% 108.52 KB 108.52 KB 34.77 KB 34.77 KB UMD_PROFILING
react-dom-unstable-fire.development.js 0.0% 0.0% 881.08 KB 881.08 KB 198.71 KB 198.72 KB NODE_DEV
react-dom-unstable-fire.production.min.js 0.0% 0.0% 105.49 KB 105.49 KB 33.62 KB 33.62 KB NODE_PROD
react-dom-unstable-fire.profiling.min.js 0.0% 0.0% 108.61 KB 108.61 KB 34.2 KB 34.2 KB NODE_PROFILING
ReactFire-dev.js 0.0% 0.0% 906.11 KB 906.11 KB 200.46 KB 200.46 KB FB_WWW_DEV
ReactFire-prod.js 0.0% -0.0% 322.11 KB 322.11 KB 59.02 KB 59.02 KB FB_WWW_PROD
react-dom-unstable-new-scheduler.development.js -0.0% 0.0% 879.94 KB 879.93 KB 198.19 KB 198.19 KB NODE_DEV
react-dom-unstable-new-scheduler.production.min.js 🔺+1.8% 🔺+1.5% 110.64 KB 112.63 KB 35.28 KB 35.79 KB NODE_PROD
react-dom-unstable-new-scheduler.profiling.min.js n/a n/a 0 B 115.75 KB 0 B 36.33 KB NODE_PROFILING
react-dom-test-utils.development.js 0.0% 0.0% 51.92 KB 51.92 KB 14.11 KB 14.11 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.76 KB 60.76 KB 15.84 KB 15.85 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10.69 KB 10.69 KB 3.66 KB 3.67 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.43 KB 60.43 KB 15.72 KB 15.72 KB NODE_DEV
react-dom-server.browser.development.js 0.0% 0.0% 135.49 KB 135.49 KB 35.62 KB 35.62 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 19.24 KB 19.24 KB 7.24 KB 7.24 KB UMD_PROD
react-dom-server.browser.development.js 0.0% 0.0% 131.62 KB 131.62 KB 34.69 KB 34.69 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 19.17 KB 19.17 KB 7.23 KB 7.23 KB NODE_PROD
ReactDOMServer-dev.js 0.0% 0.0% 133.88 KB 133.88 KB 34.43 KB 34.43 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% 0.0% 46.62 KB 46.62 KB 10.71 KB 10.71 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% 0.0% 133.56 KB 133.56 KB 35.24 KB 35.24 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% 0.0% 20.03 KB 20.03 KB 7.52 KB 7.53 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.21 KB 1.21 KB 705 B 706 B UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.05 KB 1.05 KB 636 B 637 B NODE_PROD
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 3.74 KB 3.74 KB 1.43 KB 1.43 KB NODE_DEV

Generated by 🚫 dangerJS

@acdlite acdlite merged commit 3a44cce into facebook:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants