Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename hover props in experimental event API and write unit tests #15283

Merged
merged 2 commits into from
Apr 1, 2019
Merged

Rename hover props in experimental event API and write unit tests #15283

merged 2 commits into from
Apr 1, 2019

Conversation

behzad888
Copy link
Contributor

Note: this is for an experimental event API and writing tests.

  • onHoverIn -> onHoverStart
  • onHoverOut -> onHoverEnd
  • Write unit tests

trueadm
trueadm approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution – it's awesome! It all looks good to me. I'm also a bit surprised to be honest that people externally are playing with this API. I'd be interested to know how it works out for you too. :)

@trueadm trueadm merged commit 5ef0d1d into facebook:master Apr 1, 2019
@necolas necolas mentioned this pull request Apr 1, 2019
Closed
@behzad888
Copy link
Contributor Author

behzad888 commented Apr 2, 2019 •
edited
Loading

Thank you for this contribution – it's awesome! It all looks good to me. I'm also a bit surprised to be honest that people externally are playing with this API. I'd be interested to know how it works out for you too. :)

LGTM.
I'm trying to prepare a blog about react experimental event API. In that, I want to explain how to use and how it works out.

@gaearon
Copy link
Collaborator

gaearon commented Apr 2, 2019

You'll want to be very clear it's completely experimental and not really usable outside of this repository yet. We might scrap the whole thing altogether.

@trueadm
Copy link
Contributor

trueadm commented Apr 2, 2019

Like Dan said, this isn’t to be used right now and is likely to change in API frequently too. Furthermore, we might not even use it. I’d recommend holding off for now. :)

@behzad888
Copy link
Contributor Author

Ok. Thank you for your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@behzad888 @gaearon @trueadm @facebook-github-bot