Add additional event API responder surfaces #15248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: 700f17b...6557cfa react-dom
react-events
Generated by 🚫 dangerJS |
trueadm
changed the title
trueadm
changed the title
|
👀 I really like how this is shaping up. |
necolas
approved these changes
Mar 29, 2019
| import {REACT_EVENT_COMPONENT_TYPE} from 'shared/ReactSymbols'; | ||
|
|
||
| const targetEventTypes = ['pointerdown', 'pointercancel']; | ||
| const rootEventTypes = ['pointerup', {name: 'pointermove', passive: false}]; |
There was a problem hiding this comment.
I think we could document why certain events are not passive throughout these event module implementations.
| listener: (e: Object) => void, | ||
| state: DragState, | ||
| discrete: boolean, | ||
| eventData?: { |
There was a problem hiding this comment.
We should figure out the event shapes we want for these events. Drag will probably need the delta, coordinates in space, offset from initial position, and velocity.
|
|
||
| if ( | ||
| props.onShouldClaimOwnership && | ||
| props.onShouldClaimOwnership() |
There was a problem hiding this comment.
This prop name doesn't seem quite right. In the RN responder system there are onStartShouldSetResponder and onMoveShouldSetResponder props to determine whether the view wants to become the responder after a start or move event.
| } | ||
| break; | ||
| } | ||
| case 'pointercancel': |
There was a problem hiding this comment.
we might eventually want a separate event to be called if the drag is cancelled
| import {REACT_EVENT_COMPONENT_TYPE} from 'shared/ReactSymbols'; | ||
|
|
||
| const targetEventTypes = [ | ||
| {name: 'focus', passive: true, capture: true}, |
There was a problem hiding this comment.
curious why these need to be passive and capture
| if (props.onSwipeLeft && direction === 3) { | ||
| dispatchSwipeEvent( | ||
| context, | ||
| 'swipeleft', |
There was a problem hiding this comment.
I think it might be preferable to have a single event like onSwipe with event data that provides the direction, velocity, etc. That would be simpler to work with in userland than potentially listening to 4 events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is for an experimental event API that we're testing out internally at Facebook.
This PR adds more event responder surfaces, fills in the TODOs around the responder ownership model and also fixes some bugs found with internal user testing.