[Partial Hydration] Render client-only content at normal priority #15061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will need different logic. In this commit, no logic has changed, only moved.
If the dehydrated suspense boundary's fallback content is terminal there is nothing to show. We need to get actual content on the screen soon. If we deprioritize that work to offscreen, then the timeout heuristics will be wrong. Therefore, if we have no current and we're already at terminal fallback state we'll immediately schedule a deletion and upgrade to real suspense.
Details of bundled changes.Comparing: d0289c7...bc068d6 react-dom
react-art
react-native-renderer
react-test-renderer
react-reconciler
Generated by 🚫 dangerJS |
sebmarkbage
changed the title
|
I think this is still a problem if there is one more suspense boundary around this which has content. In that scenario that boundary will hydrate at offscreen and the same thing happens. |
|
There is a conflict between our normal heuristic that dehydrated boundaries should be hydrated at offscreen priority. We can do that because there is no reason to hydrate content faster than that if it’s already being displayed. However if there is nested fallback content that can only be displayed by client rendering it which has higher pri. But we can’t get there unless we first render the parent which is lower pri. |
|
The new approach just schedules the client content at higher pri once it gets there. It means that it can be delayed compared to when it would normally be rendered but that seems fine. That only happens if you start interacting anyway. This is kind of non-idiomatic anyway because you’re expected to server render everything in the normal case. |
sebmarkbage
changed the title
acdlite
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the dehydrated suspense boundary's fallback content is terminal there is nothing to show. We need to get actual content on the screen soon.
If we deprioritize that work to offscreen, then the timeout heuristics will be wrong.
Therefore, if we have no current and we're already at terminal fallback state we'll immediately schedule a deletion and upgrade to real suspense.
Ideally, if we're in a pending state, we should also just register the listener instead of retrying at offscreen, but meh.
The first commit is from another branch I needed to factor out but might as well include it here.