Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESLint] Clearer messages #15053

Merged
merged 1 commit into from
Mar 7, 2019
Merged

[ESLint] Clearer messages #15053

merged 1 commit into from
Mar 7, 2019

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Mar 7, 2019

Made one warning a bit longer (and removed a confusing case where it hurt more than helped). Made other warnings shorter and to the point.

@gaearon gaearon requested review from trueadm and threepointone March 7, 2019 14:52
@gaearon gaearon merged commit eb6247a into facebook:master Mar 7, 2019
trueadm
trueadm reviewed Mar 7, 2019
View reviewed changes
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm left review comments

@threepointone threepointone Awaiting requested review from threepointone

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaearon @trueadm @facebook-github-bot