Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suspended children are hidden before layout in persistent mode #15030

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Mar 6, 2019

Based on #15029 and #15013

Refs behave differently in persistent mode, so instead of a ref, the persistent mode version of this test asserts on the output of the host tree.

@acdlite acdlite requested a review from sebmarkbage March 6, 2019 04:43
@acdlite acdlite changed the title Hide before layout persistent Test suspended children are hidden before layout in persistent mode Mar 6, 2019
@acdlite acdlite force-pushed the hide-before-layout-persistent branch from 360ad08 to cafb66a Compare March 6, 2019 04:46
@sizebot
Copy link

sizebot commented Mar 6, 2019

Details of bundled changes.

Comparing: bc8bd24...71fcff1

react-noop-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-noop-renderer.development.js +3.9% +0.8% 25.2 KB 26.17 KB 6.14 KB 6.19 KB NODE_DEV
react-noop-renderer.production.min.js 🔺+4.9% 🔺+1.4% 9.21 KB 9.67 KB 3.05 KB 3.09 KB NODE_PROD
react-noop-renderer-persistent.development.js +3.8% +0.7% 25.32 KB 26.29 KB 6.15 KB 6.2 KB NODE_DEV
react-noop-renderer-persistent.production.min.js 🔺+4.9% 🔺+1.4% 9.23 KB 9.69 KB 3.05 KB 3.1 KB NODE_PROD
react-noop-renderer-server.development.js 0.0% -0.1% 1.83 KB 1.83 KB 876 B 875 B NODE_DEV

Generated by 🚫 dangerJS

@acdlite acdlite force-pushed the hide-before-layout-persistent branch from cafb66a to 25a9106 Compare March 6, 2019 23:07
Refs behave differently in persistent mode, so instead of a ref, the
persistent mode version of this test asserts on the output of the
host tree.
@acdlite acdlite force-pushed the hide-before-layout-persistent branch from 25a9106 to 71fcff1 Compare March 11, 2019 17:59
@acdlite acdlite merged commit 6a4a261 into facebook:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants