[ESLint] Enforce deps array in useMemo and useCallback #15025
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They serve no purpose without a deps array. We have a similar rule on internally and it caught mistakes.
We still allow it from type perspective. In the future we might have a smart compiler that fills them in. But if you use this rule, you're doing it manually so you should be aware when your optimization doesn't work.
This is also a missing piece for the
useCallback
enforcement thing I'm working on separately. I'll send another PR for that.