Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include component stack in 'act(...)' warning #14855

Merged
merged 3 commits into from
Feb 14, 2019

Conversation

threepointone
Copy link
Contributor

Folks aren't seeing stack traces for their calls in their jest setups, so this PR includes a component stack trace to make it easier to locate and wrap with act(...).

@threepointone threepointone changed the title Act component trace include component stack in 'act(...)' warning Feb 14, 2019
@@ -1815,8 +1815,9 @@ export function warnIfNotCurrentlyBatchingInDev(fiber: Fiber): void {
'});\n' +
'/* assert on the output */\n\n' +
"This ensures that you're testing the behavior the user would see in the browser." +
' Learn more at https://fb.me/react-wrap-tests-with-act',
' Learn more at https://fb.me/react-wrap-tests-with-act\n%s',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this newline necessary? I thought stack starts with a newline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair, removed.

@gaearon gaearon merged commit c555c00 into facebook:master Feb 14, 2019
This was referenced Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants