Revert "[ShallowRenderer] Queue/rerender on dispatched action after render component with hooks" #14839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
deleted the
revert-14802-rodrigopr/shallow-dispatch-out-of-render
branch
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
…ender component with hooks (#14802)" (#14839) This reverts commit 6d4038f0a638d82e9e528f02cc5a86afb410cf11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #14802
This is not the right fix. This takes the code branch that was written for render phase updates, and reuses it for regular updates. Maybe it works, maybe it doesn't.
If we want to fix it, let's rename the variables and make sure the code actually works for general updates, and not just render phase updates. I have no confidence that it does because it was adapted 1:1 from the server renderer.