Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special case crossOrigin for SVG image elements #14832

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

aweary
Copy link
Contributor

@aweary aweary commented Feb 12, 2019

Resolves #14829

According to the SVG2 spec crossOrigin is allowed on certain SVG elements. We already had a special case for tabIndex which also exists in both the HTML and SVG specs, so this extends that to crossOrigin

I verified locally that this renders the corssOrigin attribute as lowercase.

Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approval party!

@aweary aweary merged commit fa6205d into facebook:master Feb 13, 2019
This was referenced Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants