Move Hook mismatch warning to first mismatch site #14720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdlite
force-pushed
the
move-hooks-mismatch-warning
branch
from
4022317
to
d90134d
Compare
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: cb1ff43...abde12b react-dom
react-art
react-native-renderer
react-test-renderer
react-reconciler
Generated by 🚫 dangerJS |
acdlite
commented
Jan 29, 2019
Allows us to localize the warning logic in one place.
|
Rebased on master |
acdlite
force-pushed
the
move-hooks-mismatch-warning
branch
3 times, most recently
from
77f40ff
to
67892af
Compare
threepointone
approved these changes
Jan 30, 2019
| @@ -98,10 +98,6 @@ type HookType = | |||
| | 'useImperativeHandle' | |||
| | 'useDebugValue'; | |||
|
|
|||
| // the first instance of a hook mismatch in a component, | |||
| // represented by a portion of its stacktrace | |||
| let currentHookMismatchInDev = null; | |||
There was a problem hiding this comment.
we were including the trace so peeps could tell which (possibly custom hook) was the offending one. fine to remove?
There was a problem hiding this comment.
I suppose in this case the trace would be the stack of the warning itself?
There was a problem hiding this comment.
right, of course the warning would have its own trace. thanks!
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
* Move Hook mismatch warning to first mismatch site Allows us to localize the warning logic in one place. * Nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to localize the warning logic in one place.