Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directory details to the package.json of all packages #14628

Merged
merged 1 commit into from
Jan 18, 2019
Merged

Add directory details to the package.json of all packages #14628

merged 1 commit into from
Jan 18, 2019

Conversation

greysteil
Copy link
Contributor

@greysteil greysteil commented Jan 18, 2019

Specifying the directory as part of the repository field in a package.json allows third party tools to provide better support when working with monorepos. For example, it allows them to correctly construct a commit diff for a specific package.

This format was accepted by npm in npm/rfcs#19.

Specifying the directory as part of the `repository` field in a `package.json`
allows third party tools to provide better support when working with monorepos.
For example, it allows them to correctly construct a commit diff for a specific
package.

This format was accepted by npm in npm/rfcs#19.
@gaearon
Copy link
Collaborator

gaearon commented Jan 18, 2019

Are we sure this won't break some other tools relying on it being a string? I'd like to see some smaller packages do that first as pilot.

@greysteil
Copy link
Contributor Author

@gaearon - certain, unless they've built something insanely hacky that doesn't support the normal object syntax. The string is just syntactic sugar provided by npm - it gets converted to an object in the API response. See http://registry.npmjs.org/react-dom.

@gaearon gaearon merged commit b66e6e4 into facebook:master Jan 18, 2019
@gaearon
Copy link
Collaborator

gaearon commented Jan 18, 2019

Seems good. Thanks.

jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
…4628)

Specifying the directory as part of the `repository` field in a `package.json`
allows third party tools to provide better support when working with monorepos.
For example, it allows them to correctly construct a commit diff for a specific
package.

This format was accepted by npm in npm/rfcs#19.
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
…4628)

Specifying the directory as part of the `repository` field in a `package.json`
allows third party tools to provide better support when working with monorepos.
For example, it allows them to correctly construct a commit diff for a specific
package.

This format was accepted by npm in npm/rfcs#19.
NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020
Specifying the directory as part of the `repository` field in a `package.json`
allows third party tools to provide better support when working with monorepos.
For example, it allows them to correctly construct a commit diff for a specific
package.

This format was accepted by npm in npm/rfcs#19.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants