-
Notifications
You must be signed in to change notification settings - Fork 46.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable getDerivedStateFromError #13746
Commits on Sep 27, 2018
-
Removed the enableGetDerivedStateFromCatch feature flag (aka permanen…
…tly enabled the feature)
Brian Vaughn committedSep 27, 2018 Configuration menu - View commit details
-
Copy full SHA for 4ed84b0 - Browse repository at this point
Copy the full SHA 4ed84b0View commit details -
Forked/copied ReactErrorBoundaries to ReactLegacyErrorBoundaries for …
…testing componentDidCatch
Brian Vaughn committedSep 27, 2018 Configuration menu - View commit details
-
Copy full SHA for cd49672 - Browse repository at this point
Copy the full SHA cd49672View commit details -
Updated error boundaries tests to apply to getDerivedStateFromCatch a…
…nd fixed a minor reconciliation error in begin work.
Brian Vaughn committedSep 27, 2018 Configuration menu - View commit details
-
Copy full SHA for 56bbf1c - Browse repository at this point
Copy the full SHA 56bbf1cView commit details -
Renamed getDerivedStateFromCatch -> getDerivedStateFromError
Brian Vaughn committedSep 27, 2018 Configuration menu - View commit details
-
Copy full SHA for f6fb111 - Browse repository at this point
Copy the full SHA f6fb111View commit details -
Warn if boundary with only componentDidCatch swallows error
Brian Vaughn committedSep 27, 2018 Configuration menu - View commit details
-
Copy full SHA for 3df17ba - Browse repository at this point
Copy the full SHA 3df17baView commit details
Commits on Sep 28, 2018
-
Changed componentDidCatch state-update detection logic based on feedb…
…ack from Andrew
Brian Vaughn committedSep 28, 2018 Configuration menu - View commit details
-
Copy full SHA for 233459a - Browse repository at this point
Copy the full SHA 233459aView commit details -
Updated a few tests to account for a new DEV warning
Brian Vaughn committedSep 28, 2018 Configuration menu - View commit details
-
Copy full SHA for 9943c6c - Browse repository at this point
Copy the full SHA 9943c6cView commit details -
Changed componentDidCatch no-state-update warning message to remove m…
…ention of throw I think this is confusing because it implies that gDSFE can throw and cDC will still be called, when that is not the case (because cDC is a commit phase lifecycle- and if gDSFE rethrows, the boundary in question will never mount and the commit phase menthods it defines will not be called.
Brian Vaughn committedSep 28, 2018 Configuration menu - View commit details
-
Copy full SHA for 54f637f - Browse repository at this point
Copy the full SHA 54f637fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 574f68e - Browse repository at this point
Copy the full SHA 574f68eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1171b7 - Browse repository at this point
Copy the full SHA f1171b7View commit details