-
Notifications
You must be signed in to change notification settings - Fork 46.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Jest test to verify UMD API-forwarding for scheduling package #13532
Merged
bvaughn
merged 4 commits into
facebook:master
from
bvaughn:scheduler-umd-api-forwarding-test
Sep 1, 2018
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b8ebd45
Added Jest test to verify UMD API-forwarding for scheduling package
152d8d6
Add test for SECRET_INTERNALS object too
3016a1d
Added separate dev/prod UMD bundles for scheduler package. Updated te…
3a33a3d
UMD API test should only run against source
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
95 changes: 95 additions & 0 deletions
95
packages/react-scheduler/npm/umd/react-scheduler-tracking.production.min.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
/** | ||
* @license React | ||
* | ||
* Copyright (c) 2013-present, Facebook, Inc. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
(function(global, factory) { | ||
typeof exports === 'object' && typeof module !== 'undefined' | ||
? (module.exports = factory(require('react'))) | ||
: typeof define === 'function' && define.amd // eslint-disable-line no-undef | ||
? define(['react'], factory) // eslint-disable-line no-undef | ||
: (global.ReactSchedulerTracking = factory(global)); | ||
})(this, function(global) { | ||
function __getInteractionsRef() { | ||
return global.React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.SchedulerTracking.__getInteractionsRef.apply( | ||
this, | ||
arguments | ||
); | ||
} | ||
|
||
function __getSubscriberRef() { | ||
return global.React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.SchedulerTracking.__getSubscriberRef.apply( | ||
this, | ||
arguments | ||
); | ||
} | ||
|
||
function unstable_clear() { | ||
return global.React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.SchedulerTracking.unstable_clear.apply( | ||
this, | ||
arguments | ||
); | ||
} | ||
|
||
function unstable_getCurrent() { | ||
return global.React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.SchedulerTracking.unstable_getCurrent.apply( | ||
this, | ||
arguments | ||
); | ||
} | ||
|
||
function unstable_getThreadID() { | ||
return global.React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.SchedulerTracking.unstable_getThreadID.apply( | ||
this, | ||
arguments | ||
); | ||
} | ||
|
||
function unstable_subscribe() { | ||
// eslint-disable-next-line max-len | ||
return global.React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.SchedulerTracking.unstable_subscribe.apply( | ||
this, | ||
arguments | ||
); | ||
} | ||
|
||
function unstable_track() { | ||
return global.React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.SchedulerTracking.unstable_track.apply( | ||
this, | ||
arguments | ||
); | ||
} | ||
|
||
function unstable_unsubscribe() { | ||
// eslint-disable-next-line max-len | ||
return global.React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.SchedulerTracking.unstable_unsubscribe.apply( | ||
this, | ||
arguments | ||
); | ||
} | ||
|
||
function unstable_wrap() { | ||
return global.React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.SchedulerTracking.unstable_wrap.apply( | ||
this, | ||
arguments | ||
); | ||
} | ||
|
||
return Object.freeze({ | ||
__getInteractionsRef: __getInteractionsRef, | ||
__getSubscriberRef: __getSubscriberRef, | ||
unstable_clear: unstable_clear, | ||
unstable_getCurrent: unstable_getCurrent, | ||
unstable_getThreadID: unstable_getThreadID, | ||
unstable_subscribe: unstable_subscribe, | ||
unstable_track: unstable_track, | ||
unstable_unsubscribe: unstable_unsubscribe, | ||
unstable_wrap: unstable_wrap, | ||
}); | ||
}); |
File renamed without changes.
45 changes: 45 additions & 0 deletions
45
packages/react-scheduler/npm/umd/react-scheduler.production.min.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
/** | ||
* @license React | ||
* | ||
* Copyright (c) 2013-present, Facebook, Inc. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
(function(global, factory) { | ||
typeof exports === 'object' && typeof module !== 'undefined' | ||
? (module.exports = factory(require('react'))) | ||
: typeof define === 'function' && define.amd // eslint-disable-line no-undef | ||
? define(['react'], factory) // eslint-disable-line no-undef | ||
: (global.ReactScheduler = factory(global)); | ||
})(this, function(global) { | ||
function unstable_now() { | ||
return global.React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.Scheduler.unstable_now.apply( | ||
this, | ||
arguments | ||
); | ||
} | ||
|
||
function unstable_scheduleWork() { | ||
return global.React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.Scheduler.unstable_scheduleWork.apply( | ||
this, | ||
arguments | ||
); | ||
} | ||
|
||
function unstable_cancelScheduledWork() { | ||
return global.React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.Scheduler.unstable_cancelScheduledWork.apply( | ||
this, | ||
arguments | ||
); | ||
} | ||
|
||
return Object.freeze({ | ||
unstable_now: unstable_now, | ||
unstable_scheduleWork: unstable_scheduleWork, | ||
unstable_cancelScheduledWork: unstable_cancelScheduledWork, | ||
}); | ||
}); |
41 changes: 41 additions & 0 deletions
41
packages/react-scheduler/src/__tests__/SchedulingUMDBundle-test.internal.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/** | ||
* Copyright (c) 2013-present, Facebook, Inc. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
* @jest-environment node | ||
*/ | ||
'use strict'; | ||
|
||
describe('Scheduling UMD bundle', () => { | ||
beforeEach(() => { | ||
// Fool SECRET_INTERNALS object into including UMD forwarding methods. | ||
global.__UMD__ = true; | ||
|
||
jest.resetModules(); | ||
}); | ||
|
||
function compareAPIS(apis) { | ||
apis = apis.map(api => Object.keys(api).sort()); | ||
for (let i = 1; i < apis.length; i++) { | ||
expect(apis[0]).toEqual(apis[i]); | ||
} | ||
} | ||
|
||
it('should define the same scheduling API', () => { | ||
const umdAPIDev = require('../../npm/umd/react-scheduler.development'); | ||
const umdAPIProd = require('../../npm/umd/react-scheduler.production.min'); | ||
const cjsAPI = require('../../index'); | ||
const secretAPI = require('react/src/ReactSharedInternals').default; | ||
compareAPIS([umdAPIDev, umdAPIProd, cjsAPI, secretAPI.Scheduler]); | ||
}); | ||
|
||
it('should define the same tracking API', () => { | ||
const umdAPIDev = require('../../npm/umd/react-scheduler-tracking.development'); | ||
const umdAPIProd = require('../../npm/umd/react-scheduler-tracking.production.min'); | ||
const cjsAPI = require('../../tracking'); | ||
const secretAPI = require('react/src/ReactSharedInternals').default; | ||
compareAPIS([umdAPIDev, umdAPIProd, cjsAPI, secretAPI.SchedulerTracking]); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a bit clearer if the "source of truth" API is passed as first argument. Then you can remove the
let i = 1
special case. Also errors would be better if you dobecause it's UMD/Secrets API that are actual and the original source code that is expected.