Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interaction tracking follow up #13509

Merged
merged 12 commits into from
Sep 1, 2018
Merged

Interaction tracking follow up #13509

merged 12 commits into from
Sep 1, 2018

Commits on Sep 1, 2018

  1. Add interaction-tracking FB+www builds

    Brian Vaughn committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    477efbe View commit details
    Browse the repository at this point in the history

  2. Strip no-side-effect imports from Rollup bundles

    Brian Vaughn committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    1f5ee61 View commit details
    Browse the repository at this point in the history

  3. Access interaction-tracking API through React.unstable_interactions 

    1. For CJS bundles, this will just re-export the interaction-tracking package but for UMD builds, it will inline the functionality to avoid breaking backwards compatibility.
2. All new interaction-tracking APIs are tagged as unstabled (e.g. React.unstable_interactions.wrap, import { unstable_track } from 'interaction-tracking')
    Brian Vaughn committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    019262b View commit details
    Browse the repository at this point in the history

  4. Add InteractionTracking production bundle test

    Brian Vaughn committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    4eaa18a View commit details
    Browse the repository at this point in the history

  5. Edge case guard against a wrapped function being run multiple times

    Brian Vaughn committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    9448d38 View commit details
    Browse the repository at this point in the history

  6. Fixed fixtures/packaging

    Brian Vaughn committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    b77673b View commit details
    Browse the repository at this point in the history

  7. Export subset of interaction-tracking API required by reconciler via … 

    …SECRET_INTERNALS

This is being done so that UMD builds will continue to work without requiring a backwards breaking change.

Application code should consume the new interaction-tracking API directly from NPM. Reconciler code will access the subset of the API it needs from the SECRET_INTERNALS object in order to avoid breaking UMD builds.

As a result of this, interaction-tracking will not be supported for UMD builds.
    Brian Vaughn committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    4eec46b View commit details
    Browse the repository at this point in the history

  8. Merged interaction-tracking package into react-scheduler 

    React UMD bundles inlines the new react-scheduler package and exposes the API via the SECRET_INTERNALS object. UMD bundles of e.g. ReactDOM access the API this way. This avoids breaking backwards compat for UMD bundles (since it avoids requiring a new <script> tag).

react CJS bundles to not inline the react-scheduler package. Instead, react-dom and other renderers import the shared NPM module. A hard NPM depedency has been added to react-dom and other renderers on the new react-scheduler package so that upgrades will not require any additional npm-install steps.

A UMD bundle of the new react-scheduler also exists which defines the same public API but lazily forwards method calls to the React SECRET_INTERNALS inlined version. This allows the new API to be used in e.g. Code Pens if people want to.
    Brian Vaughn committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    f889734 View commit details
    Browse the repository at this point in the history

  9. Don't re-export react-scheduler APIs for CJS bundles

    Brian Vaughn committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    1a57f6e View commit details
    Browse the repository at this point in the history

  10. Fixed inline bundling problem and added more fixture tests

    Brian Vaughn committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    5d9edc9 View commit details
    Browse the repository at this point in the history

  11. Cleaned up inline comment about scheduling fork

    Brian Vaughn committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    c5b4db2 View commit details
    Browse the repository at this point in the history

  12. Combined react-scheduler/tracking and react-scheduler/tracking-subscr… 

    …iptions entry points
    Brian Vaughn committed Sep 1, 2018
    Configuration menu
    Copy the full SHA
    bc6f98f View commit details
    Browse the repository at this point in the history