Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw more specific error if passed undefined in React.cloneElement #12534

Merged
merged 14 commits into from
Apr 10, 2018
Merged

Throw more specific error if passed undefined in React.cloneElement #12534

Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7bc5fd5
throw error if passed undefined
Apr 4, 2018
8ee2452
should be TypeError
Apr 4, 2018
33d1edf
simplify
Apr 5, 2018
48c7b53
use invariant
Apr 5, 2018
34816fc
editor messed up spacing
Apr 5, 2018
2733707
better check
Apr 6, 2018
44df599
Revert "better check"
Apr 6, 2018
7f6d18b
Merge branch 'master' into clone-element-throw-error-on-undefined
Apr 6, 2018
baa4d84
yarn prettier test was failing
Apr 6, 2018
80de944
more explicit copy
Apr 6, 2018
e3416ee
es6 import
Apr 6, 2018
905abfc
tests
Apr 10, 2018
d20de72
formatting
Apr 10, 2018
070ef20
Move import
gaearon Apr 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/react/src/ReactElement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,11 @@ export function cloneAndReplaceKey(oldElement, newKey) {
* See https://reactjs.org/docs/react-api.html#cloneelement
*/
export function cloneElement(element, config, children) {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: extra line

if (!element) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be more specific here. Only null and undefined trigger that error, right?

Copy link
Contributor Author

@wherestheguac wherestheguac Apr 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it’s basically a cannot read property ‘props’ of undefined/null problem where it tries to copy the props of the original element I think. So it should explicitly check if element is null or element is undefined and throw a specific error for each of those cases?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One error for both cases is fine

throw new TypeError('Cannot clone null or undefined.');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the rest of the codebase we use a function called invariant for errors. That integrates with our system that replaces error messages with error codes in production builds. Could you use it here too?

invariant(false, 'message')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that’s really cool, I’ll put that in there

}

let propName;

// Original props are copied
Expand Down