Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first set of for...of removals to get rid of eslint disables #12401

Closed
wants to merge 1 commit into from
Closed

first set of for...of removals to get rid of eslint disables #12401

wants to merge 1 commit into from

Conversation

JoeCortopassi
Copy link
Contributor

@JoeCortopassi JoeCortopassi commented Mar 19, 2018

[work in progress]: Cleaning up the relics of the for...of left from #12198

@JoeCortopassi
Copy link
Contributor Author

@gaearon noticed you wanted for...of loops disabled as part of #12198, and marked a few as such.

Before I finish this, can you confirm this is wanted and I'm not cleaning up loops that were meant to be left alone

@pull-bot
Copy link

Fails
🚫

node` failed.

Log

Error:  { FetchError: invalid json response body at http://react.zpao.com/builds/master/_commits/e1ff342bf7f451fb995e0ea2bfb10889deef022f/results.json reason: Unexpected token < in JSON at position 0
    at /home/circleci/project/node_modules/node-fetch/lib/body.js:48:31
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
  name: 'FetchError',
  message: 'invalid json response body at http://react.zpao.com/builds/master/_commits/e1ff342bf7f451fb995e0ea2bfb10889deef022f/results.json reason: Unexpected token < in JSON at position 0',
  type: 'invalid-json' }

Generated by 🚫 dangerJS

@aweary
Copy link
Contributor

aweary commented Mar 19, 2018

@JoeCortopassi for..of loops inside tests and build scripts are fine. The only cases where it matters is when the code would be included in one of the React packages. Thanks though!

@aweary aweary closed this Mar 19, 2018
@JoeCortopassi JoeCortopassi deleted the refactor branch March 19, 2018 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants