Use 'class' and 'for' for DOM property names #1223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React fixes inconsistencies in the DOM and avoids being held back by older browsers (to the extent possible). The only reason that the DOM authors chose `className` and `htmlFor` was because the JS engines of the time didn't support using `class` and `for` as unquoted property names. Changing React to use `class` and `for` agrees with our principles of improving the DOM and using modern JS, and is what most people expect when first starting with React.
| @@ -162,7 +162,7 @@ var DOMPropertyOperations = { | |||
| var propName = DOMProperty.getPropertyName[name]; | |||
| var defaultValue = DOMProperty.getDefaultValueForProperty( | |||
| node.nodeName, | |||
| name | |||
| propName | |||
There was a problem hiding this comment.
(A bug that no one noticed before.)
There was a problem hiding this comment.
Can we fix this independently? Also a new test? I'm not convinced yet that we'll take the rest.
There was a problem hiding this comment.
I suppose so. #1225
|
That sure is a valid argument |
sophiebits
added a commit
to sophiebits/react
that referenced
this pull request
Mar 6, 2014
This would make facebook#1223 easier to deal with in older browsers. With this change, <div class="orange" /> compiles into React.DOM.div( {"class":"orange"} ); and `this.props.class` turns into `this.props["class"]`.
|
+1 |
|
Don't the reserved words ( |
|
Oh sweet. Good stuff. |
|
Finding a way to make HTML attribute names work would definitely make React with JSX more approachable for new developers. But it has to be consistent - non-camelCased attribute names need to work as would attribute names with hyphens. |
|
Unfortunately this won't work with object destructuring, like var {class, color} = this.props; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React fixes inconsistencies in the DOM and avoids being held back by older browsers (to the extent possible). The only reason that the DOM authors chose
classNameandhtmlForwas because the JS engines of the time didn't support usingclassandforas unquoted property names.Changing React to use
classandforagrees with our principles of improving the DOM and using modern JS, and is what most people expect when first starting with React.