-
Notifications
You must be signed in to change notification settings - Fork 47.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix updateWrapper causing re-render textarea, even though their data … #12080
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
5eb67a0
to
34d985e
Compare
Thanks for this @joelbarbosa! I made some minor changes to bring this up to date and then added a test. @gaearon we should still do some browser testing, but on the surface this looks good to me. |
@aweary Do you want to take care of the testing? |
@gaearon yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from testing, this looks good to me 👍
I'll update this with master and do some testing. |
Well shoot, pushing to master is trickier than I thought. I've resubmitted this in #13643. I'll see it through. |
Details of bundled changes.Comparing: b488a5d...b488a5d schedule
Generated by 🚫 dangerJS |
Fix: #12072