Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Use only public API for getNodeForCharacterOffset test #11803

Closed
wants to merge 2 commits into from
Closed

(WIP) Use only public API for getNodeForCharacterOffset test #11803

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcfbfd3
(WIP) Use only public API for getNodeForCharacterOffset test (#11299)
accordeiro Dec 7, 2017
7469f03
(WIP) Improve getNodeForCharacterOffset test to exercise it via publi…
accordeiro Dec 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
156 changes: 95 additions & 61 deletions packages/react-dom/src/client/__tests__/getNodeForCharacterOffset-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,74 +9,108 @@

'use strict';

// TODO: can we express this test with only public API?
var getNodeForCharacterOffset = require('../getNodeForCharacterOffset').default;

// Create node from HTML string
function createNode(html) {
var node = (getTestDocument() || document).createElement('div');
node.innerHTML = html;
return node;
}

function getTestDocument(markup) {
var doc = document.implementation.createHTMLDocument('');
doc.open();
doc.write(
markup ||
'<!doctype html><html><meta charset=utf-8><title>test doc</title>',
);
doc.close();
return doc;
}

// Check getNodeForCharacterOffset return value matches expected result.
function expectNodeOffset(result, textContent, nodeOffset) {
expect(result.node.textContent).toBe(textContent);
expect(result.offset).toBe(nodeOffset);
}

describe('getNodeForCharacterOffset', () => {
it('should handle siblings', () => {
var node = createNode('<i>123</i><i>456</i><i>789</i>');
var React;
var ReactDOM;

expectNodeOffset(getNodeForCharacterOffset(node, 0), '123', 0);
expectNodeOffset(getNodeForCharacterOffset(node, 4), '456', 1);
beforeEach(() => {
React = require('react');
ReactDOM = require('react-dom');
});

it('should handle trailing chars', () => {
var node = createNode('<i>123</i><i>456</i><i>789</i>');
it('should re-render an input with the same selection', done => {
const container = document.createElement('div');
let node, component;
document.body.appendChild(container);

expectNodeOffset(getNodeForCharacterOffset(node, 3), '123', 3);
expectNodeOffset(getNodeForCharacterOffset(node, 9), '789', 3);
});
class InputComponent extends React.Component {
constructor(props) {
super(props);

it('should handle trees', () => {
var node = createNode(
'<i>' +
'<i>1</i>' +
'<i>' +
'<i>' +
'<i>2</i>' +
'<i></i>' +
'</i>' +
'</i>' +
'<i>' +
'3' +
'<i>45</i>' +
'</i>' +
'</i>',
);

expectNodeOffset(getNodeForCharacterOffset(node, 3), '3', 1);
expectNodeOffset(getNodeForCharacterOffset(node, 5), '45', 2);
expect(getNodeForCharacterOffset(node, 10)).toBeUndefined();
});
this.state = {
oneFirst: true,
oneValue: 'foo',
twoValue: 'foo',
};
}

componentWillMount() {
component = this;
}

handleChange(e) {
this.setState({value: e.target.value});
}

renderForms() {
if (this.state.oneFirst) {
return [
<input
key="1"
value={this.state.oneValue}
ref={e => (node = e)}
readOnly={true}
/>,
<input key="2" value={this.state.twoValue} readOnly={true} />,
];
} else {
return [
<input key="2" value={this.state.twoValue} readOnly={true} />,
<input key="1" value={this.state.oneValue} readOnly={true} />,
];
}
}

render() {
return <form>{this.renderForms()}</form>;
}
}

ReactDOM.render(<InputComponent />, container);

node.focus();
node.setSelectionRange(1, 1);

const inputDescriptor = Object.getOwnPropertyDescriptor(HTMLInputElement.prototype, 'selectionStart');

delete HTMLInputElement.prototype.selectionStart;

let startMarkerNode, startMarkerOffset;
let endMarkerNode, endMarkerOffset;

// These aren't implemented by jsdom yet, so let's re-implement them
// to test the markers created by getNodeForCharacterOffset

window.getSelection = () => ({
removeAllRanges: function() {
return true;
},
addRange: function(range) {},
extend: function(endNode, endOffset) {
endMarkerNode = endNode;
endMarkerOffset = endOffset;
},
});

it('should handle non-existent offset', () => {
var node = createNode('<i>123</i>');
document.createRange = () => ({
setStart: function(startNode, startOffset) {
startMarkerNode = startNode;
startMarkerOffset = startOffset;
},
setEnd: function(endNode, endOffset) {
endMarkerNode = endNode;
endMarkerOffset = endOffset;
},
});

expect(getNodeForCharacterOffset(node, -1)).toBeUndefined();
expect(getNodeForCharacterOffset(node, 4)).toBeUndefined();
try {
component.setState({oneFirst: false}, () => {
console.log(startMarkerNode, startMarkerOffset);
console.log(endMarkerNode, endMarkerOffset);
done();
});
} finally {
Object.defineProperty(HTMLInputElement.prototype, 'selectionStart', inputDescriptor);
}
});
});