Refactor the build scripts #11787
Refactor the build scripts #11787
Conversation
gaearon
force-pushed
the
rewrite-build
branch
from
6ae7b20 to
680f55f
Compare
scripts/rollup/build.js
Outdated
| syncReactNative, | ||
| syncReactNativeRT, | ||
| syncReactNativeCS, | ||
| } = require('./sync').syncReactDom; | ||
| const Packaging = require('./packaging'); |
There was a problem hiding this comment.
Can we also deconstruct this object rather than using Packaging?
|
I wanted to keep I'll do the same for |
| if (error.code) { | ||
| console.error( | ||
| `\x1b[31m-- ${error.code}${error.plugin ? ` (${error.plugin})` : ''} --` | ||
| console.log(`${chalk.bgRed.black(' OH NOES! ')} ${logKey}\n`); |
There was a problem hiding this comment.
There's a further console.error too so I guess it doesn't matter? The diff makes it look like I replaced one with the other, but I just added an additional one.
There was a problem hiding this comment.
To be honest I'm not even sure what the difference on Node is 😅
There was a problem hiding this comment.
I think the only difference is that one outputs to stderr and the other to stdout. I don't think it actually matters in this case. 😁
| return; | ||
| } | ||
| console.error( | ||
| `\x1b[31m-- ${error.code}${error.plugin ? ` (${error.plugin})` : ''} --` |
There was a problem hiding this comment.
Copy paste of existing code, didn't look into how it works.
There was a problem hiding this comment.
Gotcha. Should be identical to chalk.red('string')
| } | ||
| return asyncMkDirP(path.dirname(to)).then( | ||
| () => | ||
| new Promise((resolve, reject) => { |
There was a problem hiding this comment.
Possible follow-up: We could remove this new Promise boilerplate here and below using Promise.denodeify
This might be a bit hard to review since a few things moved around.
The code that produces the bundles is exactly the same (just split into a few methods).
This mostly changes the code that copies folders and shims:
process.exit()all over the place, and instead use the normal try/catch flow.asyncCopyTofunction to do that automatically.Note I mostly rewrote the folder moving file from scratch.
I found it easier than refactoring the old one.