Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shared: convert vars into let/const #11730

Merged
merged 1 commit into from
Dec 1, 2017
Merged

shared: convert vars into let/const #11730

merged 1 commit into from
Dec 1, 2017

Conversation

raphamorim
Copy link
Contributor

Ref: #11699

@raphamorim raphamorim mentioned this pull request Nov 30, 2017
Merged
@raphamorim raphamorim changed the title events: convert vars into let/const shared: convert vars into let/const Nov 30, 2017
@gaearon gaearon merged commit 6c1fba5 into facebook:master Dec 1, 2017
@gaearon
Copy link
Collaborator

gaearon commented Dec 1, 2017

Is there anything left?

@raphamorim raphamorim deleted the shared/no-more-vars branch December 1, 2017 00:08
@raphamorim
Copy link
Contributor Author

raphamorim commented Dec 1, 2017 •
edited
Loading

missing react-noop-renderer.
I'll finish it and be done :octocat:

Sorry for these many PRs @gaearon 😢

@raphamorim raphamorim mentioned this pull request Dec 1, 2017
Closed
@marcelometal marcelometal mentioned this pull request Oct 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raphamorim @gaearon @facebook-github-bot