Convert scripts/error-codes to use ES6 syntax #11697
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| '__DEV__ ? ' + | ||
| "invariant(false, 'Do not override existing functions.') : " + | ||
| `_prodInvariant('16') : void 0;` | ||
| `import _prodInvariant from 'shared/reactProdInvariant';\nimport invariant from 'shared/reactProdInvariant';\n!condition ? __DEV__ ? invariant(false, 'Do not override existing functions.') : ${`_prodInvariant('16') : void 0;`}` |
There was a problem hiding this comment.
I don't think this is easier to read.
scripts/error-codes/codes.json
Outdated
| @@ -1,252 +1,252 @@ | |||
| { | |||
| "0": "React.addons.createFragment(...): Encountered an invalid child; DOM elements are not valid children of React components.", | |||
There was a problem hiding this comment.
This file is autogenerated. No need to change it.
There was a problem hiding this comment.
Sorry! I've forgotten to revert this 😢
|
@gaearon what does that mean? |
|
You need to run |
gaearon
changed the title
|
Looks good, thanks |
If need be, I can squash the commits.