Deprecate injecting custom event plugins #11690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiebits
approved these changes
Nov 28, 2017
|
I can also just change how we do this for FB to (temporary) static injection. I wanted to stop exposing dynamic injection anyway. |
gaearon
force-pushed
the
deprecate-injection
branch
2 times, most recently
from
9456d95 to
e2e1bba
Compare
gaearon
force-pushed
the
deprecate-injection
branch
from
e2e1bba to
73ce7c5
Compare
aweary
approved these changes
Nov 29, 2017
I just checked, and it does. |
madeinfree
pushed a commit
to madeinfree/react
that referenced
this pull request
Nov 30, 2017
* Deprecate injecting custom event plugins * Fix up tests * Fix CI * oh noes
This was referenced Jun 24, 2023
This was referenced Nov 30, 2023
This was referenced Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's time we do this IMO. See #11689.
Internally I plan to fix up the remaining five or so callsites by hand.
In any case, the ecosystem should migrate earlier since it's a trail of dependencies.