Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to reset the forceUpdate flag after the update #11440

Merged
merged 2 commits into from
Nov 3, 2017

Conversation

koba04
Copy link
Contributor

@koba04 koba04 commented Nov 3, 2017

This is a PR to follow up #11439.
Currently, _forcedUpdate flag is never reset until shouldComponentUpdate returns false so A test in this PR doesn't pass.

This is a PR to fix this.
I think the flag can be reset after the render.

@koba04
Copy link
Contributor Author

koba04 commented Nov 3, 2017

I should have commented this to the PR.
But I couldn't make it before it's merged💨

@gaearon
Copy link
Collaborator

gaearon commented Nov 3, 2017

Thanks for catching this. I decided to restructure the code a bit to better match how we do it in the real reconciler. Also added support for PureComponent while I’m there.

@gaearon gaearon merged commit e8a3823 into facebook:master Nov 3, 2017
@koba04
Copy link
Contributor Author

koba04 commented Nov 3, 2017

Thanks! 👏 I forgot about PureComponent! 😅

@koba04 koba04 deleted the fix-shallow-renderer-forceupdate branch November 3, 2017 16:00
Ethan-Arrowood pushed a commit to Ethan-Arrowood/react that referenced this pull request Dec 8, 2017
* Fix to reset the forceUpdate flag after the update

* Add support for PureComponent and mirror real behavior closer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants