-
Notifications
You must be signed in to change notification settings - Fork 47.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SyntheticClipboardEvent tests to only use the public API #11365
Merged
gaearon
merged 10 commits into
facebook:master
from
smaniotto:bernardo/clipboard-events-public-api
Nov 10, 2017
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
05cf902
Refactor SyntheticClipboardEvent tests to only use the public API
smaniotto 66a0496
Merge branch 'master' into bernardo/clipboard-events-public-api
gaearon 5a45e2f
Replace local document creation by document body reset on each test c…
smaniotto 8a855d6
Merge branch 'master' into bernardo/clipboard-events-public-api
gaearon 7843de1
Set up and tear down container separately
gaearon 6746cb2
Tweak test assertion logic for clarity
gaearon 21b7bda
Remove simulate abstraction and create events directly
gaearon 5cf9b45
Ensure the test covers IE8 behavior
gaearon 5f728a6
Merge branch 'master' into smaniotto-bernardo/clipboard-events-public…
gaearon 3cf7e3a
Verify that persistence works
gaearon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this test specifically verifies that the synthetic event still determines the target even if only
srcElement
was set. Your test doesn't verify this.