Add note to 'unreleased' CHANGELOG about deprecating Bower #11262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**what is the change?:** We will no longer release new versions of React to Bower, and we should announce that as part of our CHANGELOG. **why make this change?:** We decided on this as a team. **test plan:** Visual inspection and spell check. :) **issue:** Just follow-up for facebook#11223
gaearon
reviewed
Oct 17, 2017
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ | |||
| ### All Packages | |||
|
|
|||
| * Fix an accidental extra global variable in the UMD builds. ([@gaearon](https://github.com/gaearon) in [#10935](https://github.com/facebook/react/pull/10935)) | |||
| * Deprecate use of Bower for accessing React packages. We will no longer be using Bower. ([@bvaughn](https://github.com/bvaughn) in [#11223](https://github.com/facebook/react/pull/11223)) | |||
There was a problem hiding this comment.
This sounds like something we've done in React code itself.
It also sounds like existing Bower users will be negatively affected.
I would instead add a separate section like
Discontinuing Bower Releases
Starting with 16.1.0, we will no longer be publishing new releases on Bower. You can continue using Bower for old releases, or point your Bower configs to the React UMD builds hosted on unpkg that mirror npm releases and will continue to be updated.
I don't think attribution is needed here since it's a team decision and more of a policy change than a behavior change.
There was a problem hiding this comment.
Good idea! Will fix.
gaearon
reviewed
Oct 18, 2017
CHANGELOG.md
Outdated
| @@ -37,6 +37,11 @@ | |||
| * Fix multiple `setState()` calls in `componentWillMount()` in shallow renderer. ([@Hypnosphi](https://github.com/Hypnosphi) in [#11167](https://github.com/facebook/react/pull/11167)) | |||
| * Add back support for running in production mode. ([@gaearon](https://github.com/gaearon) in [#11112](https://github.com/facebook/react/pull/11112)) | |||
|
|
|||
|
|
|||
| ### Discontinuing Bower Releases | |||
There was a problem hiding this comment.
Let's put it on top to make it hard to miss?
gaearon
approved these changes
Oct 18, 2017
|
|
bvaughn
approved these changes
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is the change?:
We will no longer release new versions of React to Bower, and we should
announce that as part of our CHANGELOG.
why make this change?:
We decided on this as a team.
test plan:
Visual inspection and spell check. :)
issue:
Just follow-up for #11223