Header component search input fixed for mobile #10749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
force-pushed
the
gatsby-mobile-search
branch
from
5086fd5 to
99f4b55
Compare
|
Deploy preview ready! Built with commit f71981d |
bvaughn
changed the title
|
Merging for my own convenience but happy to make changes via follow-up PRs |
flarnie
reviewed
Sep 20, 2017
|
Thanks Flarnie! |
This was referenced May 20, 2020
This was referenced Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header
Popup
The mobile CSS is pretty hacky, but then again- so is the entire algolia.css file. I'm not too concerned about it though since one of our follow-up items (post launch) is to replace it with a client-side search.
The popup is also a bit blurry on mobile. This has something to do with the fixed position, but I'm not sure what else is causing it. Since it impacts mobile only, and we plan to replace this popup soon, I don't consider it a blocker.
cc @joecritch