Skip to content

Adding onSelectionChange #10746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

YurkaninRyan
Copy link

Hi everyone! This PR definitely isn't ready to go in yet (tests, code style, and CLA all still need to be completed), but I wanted to get it up here to try and foster some discussion.

Currently, there is no way to listen to the selectionchange event unless you do it outside the React Event System. I was wondering if there was room to add that functionality.

I know that the current onSelect plugin is a bit different then the actual select event listener. And that it actually will try to use selectionchange if possible. I wasn't sure if this improvement would require a whole new type of event, or if we should just augment onSelect.

Thoughts?

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@YurkaninRyan YurkaninRyan changed the title Adding onSelectionChange Adding`onSelectionChange Sep 19, 2017
@YurkaninRyan YurkaninRyan changed the title Adding`onSelectionChange Adding onSelectionChange Sep 19, 2017
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Collaborator

gaearon commented Jan 5, 2018

Thanks for the PR! Given the community focus on the file size I don't see us adding more event polyfills in the future, even for useful events. Maybe if you expose it directly without a polyfill we could take it.

@gaearon gaearon closed this Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants