-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass pendingProps
as argument in createWorkInProgress
#10643
Conversation
Here is the callsite that hasn't been updated. It's confusing when functions take different number of arguments in different cases. What do you think should happen? Should we pass And why did Flow not catch the missing argument? |
Hi @gaearon, And for Flow, I'm not sure why it not catch. Let me update the pr : ) |
I asked @acdlite to look at this when he finds time since it’s his TODO originally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also update all the places where we mutate pendingProps
directly. There are a bunch in ReactChildFiber, like
existing.pendingProps = element.props; |
(In any case let's defer this until after 16) |
Also let's wait until expiration times lands because it will be a pain to resolve the conflicts. #10426 |
Got it. I will update after 16 & #10426 |
Update
createWorkInProgress
inReactFiber.js
to acceptpendingProps
as argument.