Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsx --watch crash #957

Closed
mtgred opened this issue Jan 23, 2014 · 6 comments · Fixed by #981
Closed

jsx --watch crash #957

mtgred opened this issue Jan 23, 2014 · 6 comments · Fixed by #981

Comments

@mtgred
Copy link

mtgred commented Jan 23, 2014

When I run jsx --watch src/ build/ it compiles the jsx files and create a .lock.pid file in the build directory.

On the next jsx file modification, the jsx process crashes. Once the .lock.pid is present, jsx won't compile jsx files even when ran manually.

I use OSX Maverick and jsx 0.8.13.

@syranide
Copy link
Contributor

AFAIK this is a "bug" with commoner or whatever JSX relies on to expose that feature. Just make sure to close the watch instance instead of just closing the terminal/powering down and it should be fine.

@benjamn
Copy link
Contributor

benjamn commented Jan 23, 2014

Does it work again if you remove the .lock.pid file?

@syranide
Copy link
Contributor

@benjamn Yes it does. Oh or wait, the crashing.

@benjamn
Copy link
Contributor

benjamn commented Jan 23, 2014

It seems like there are two ways of fixing this. We can either

  1. figure out why this code is not cleaning up the .lock.pid file when the process exits, or
  2. remove the .lock.pid functionality and just hope people don't accidentally have multiple jsx --watch processes targeting the same output directory.

I'm pretty comfortable with option 2, honestly. Thoughts, @zpao, @spicyj, @petehunt, @syranide, @mtgred?

@syranide
Copy link
Contributor

@benjamn Yeah, no lock seems fine for me, it could warn if it was found perhaps?

Another thing to mention that has been happening to me, I'm using React through a Linux VM and accessing the filesystem through samba. When saving a file it immediately triggers a recompile before the file has finished saving, causing it to error. Shortly after it recompiles it again, so no harm, but it's worth noting.

@zpao
Copy link
Member

zpao commented Jan 23, 2014

I'm fine with no locking. I didn't even know that existed. Do what works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants