Source map support for jsx binary

[sophiebits]

Would be nice.

[vjeux]

Related: #764 Source maps on the in-browser transform

[vjeux]

#334

[benjamn]

👍

[avanderhoorn]

Just wondering what is happening with sourcemap support?

[sophiebits]

#833 is still open, hasn't been merged yet.

[avanderhoorn]

@spicyj Thanks for pointing that out! (missed it some how). Just wondering if this is shooting for the 0.11 release?

[sophiebits]

Probably not, sorry. Looks like there are still several unaddressed comments.

[avanderhoorn]

@spicyj Thanks for letting me know. Just so I get a better understanding of things, how is what is being done there different to this which looks like it will go out in 0.11 (besides support for inline vs external files, etc)?

[sophiebits]

That one has an option to produce source map files which is a bit more complicated because it needs to integrate properly with the file watching system which currently doesn't expect multiple outputs for a single input. fc5bb9c only added support for returning the source map when react-tools is used as a node library; it didn't change the command line tool.

[avanderhoorn]

@spicyj Ok so if I'm using gulp-react which uses react-tools when 0.11 comes, I will be able to inline source maps? Putting that aside once #833 is baked more, will the option to have external source maps be carried through, or would you see that as a different unit of work? Again just trying to put the pieces together in my head.

[sophiebits]

I'm not familiar with gulp-react in particular but it should be possible for it to support source maps in this new version.

[avanderhoorn]

Just this question:

once #833 is baked more, will the option to have external source maps be carried through, or would you see that as a different unit of work?

[sophiebits]

That would probably make sense as a separate PR because we probably don't want the react-tools transform API to do the actual file writing – instead it'll need to return the source map somehow, perhaps in an object containing the transformed source and the source map since it wouldn't be able to return a single string any more.

[RReverser]

#1825 was landed, can we close this or is there anything that needs to be done?

[zpao]

I think we were hoping for external .map file support too.

[zpao]

react-tools is deprecated so closing out