Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG attributes getting ignored #5763

Closed
tusharmath opened this issue Jan 1, 2016 · 7 comments
Closed

SVG attributes getting ignored #5763

tusharmath opened this issue Jan 1, 2016 · 7 comments

Comments

@tusharmath
Copy link

INPUT:

        <marker id="triangle"
    viewBox="0 0 10 10"
    refX={0} refY={5}
    markerUnits="strokeWidth"
    markerWidth="4" markerHeight="3"
    orient="auto">
    <path d="M 0 0 L 10 5 L 0 10 z"/>
</marker>

OUTPUT:

<marker id="triangle" viewBox="0 0 10 10" data-reactid=".0.1.1.0.0.1.2.1.0.1.0.0.1.0.0.1.0">
    <path d="M 0 0 L 10 5 L 0 10 z" data-reactid=".0.1.1.0.0.1.2.1.0.1.0.0.1.0.0.1.0.0"></path>
</marker>

Missing properties — refX, refY, markerUnits, orient

@rickbeerendonk
Copy link
Contributor

Marker tag also misses markerWidth and markerHeight

@zpao
Copy link
Member

zpao commented Jan 1, 2016

All attributes will be passed through to svg in the next release now that #5714 has landed. We won't be adding anymore individual attributes.

@zpao zpao closed this as completed Jan 1, 2016
@tusharmath
Copy link
Author

So, until then? When is the next release?

On Sat, Jan 2, 2016, 12:35 AM Paul O’Shannessy notifications@github.com
wrote:

Closed #5763 #5763.


Reply to this email directly or view it on GitHub
#5763 (comment).

Regards,
Tushar Mathur.
www.tusharm.com

@zpao
Copy link
Member

zpao commented Jan 3, 2016

We'll ship 0.15 when it's ready. Rough estimate: probably not in January.

@tusharmath
Copy link
Author

But what is the alternative, I am drawing all my graphs in SVG using react. Is it simply impossible to do this right now ?

@tusharmath
Copy link
Author

As of now I am using dangerouslySetInnerHTML :(
Which seems pretty dangerous to me.

@zpao
Copy link
Member

zpao commented Jan 4, 2016

That or manually calling setAttribute on your svg node are the alternatives. The escape hatches are there but they are obviously unfortunate. The situation will be better soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants